Support querying a single 24h price change pair#18
Open
Turv wants to merge 1 commit intomorpheums:masterfrom
Open
Support querying a single 24h price change pair#18Turv wants to merge 1 commit intomorpheums:masterfrom
Turv wants to merge 1 commit intomorpheums:masterfrom
Conversation
morpheums
reviewed
Jan 17, 2018
Owner
morpheums
left a comment
morpheums
left a comment
There was a problem hiding this comment.
Hi @Turv thanks for the proposed changes, but i think that having only one method is a better solution for this issue, i already solved this in the last version of the nuget package, thank you very much for using this library and feel free to submit new pull requests in case you find any other issue!
|
When was the library updated? I too experience this, and pulled the library 3 days ago. @morpheums |
Owner
|
I just released a new version today, please check it out, thanks!
El 17 ene. 2018 8:34 p. m., "weznagwama" <notifications@github.com>
escribió:
… When was the library updated? I too experience this, and pulled the
library 3 days ago. @morpheums <https://github.com/morpheums>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARLhzs38zC-QFqKtgyGDZls2WeOkQc8Rks5tLpGmgaJpZM4RWJqZ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in Ticket #15 the signature of the method GetPriceChange24H supports a symbol parameter but always expects a JSON Array to return the IEnumerable object.
When this parameter is provided the API returns a flat object, and not an array therefore this needs two different methods to support getting all price changes or a single price change.